Skip to content

chore(deps): Bump E2E tests to 0.84.0#5492

Open
antonis wants to merge 18 commits intomainfrom
antonis/rn-0.83.1
Open

chore(deps): Bump E2E tests to 0.84.0#5492
antonis wants to merge 18 commits intomainfrom
antonis/rn-0.83.1

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Dec 19, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bump E2E tests to 0.84.-RC

💡 Motivation and Context

https://github.com/facebook/react-native/releases/tag/v0.84.0

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis added ready-to-merge Triggers the full CI test suite and removed ready-to-merge Triggers the full CI test suite labels Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.82 ms 443.98 ms 35.16 ms
Size 43.75 MiB 48.41 MiB 4.66 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a206511+dirty 424.28 ms 474.82 ms 50.54 ms
000da7a 454.46 ms 445.00 ms -9.46 ms
8ff81c0+dirty 574.58 ms 611.44 ms 36.86 ms
b3b5b0d 399.82 ms 419.20 ms 19.38 ms
05bef0e+dirty 349.78 ms 334.04 ms -15.74 ms
9f211e3 451.50 ms 500.00 ms 48.50 ms
161947d+dirty 393.26 ms 403.00 ms 9.74 ms
2adbd1e+dirty 433.98 ms 427.96 ms -6.02 ms
95aaf8a 437.89 ms 419.45 ms -18.44 ms
90edad7+dirty 423.57 ms 438.92 ms 15.35 ms

App size

Revision Plain With Sentry Diff
a206511+dirty 43.75 MiB 48.07 MiB 4.32 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB
8ff81c0+dirty 43.75 MiB 48.05 MiB 4.29 MiB
b3b5b0d 17.75 MiB 19.68 MiB 1.94 MiB
05bef0e+dirty 17.75 MiB 19.70 MiB 1.95 MiB
9f211e3 17.75 MiB 19.68 MiB 1.94 MiB
161947d+dirty 17.75 MiB 19.70 MiB 1.95 MiB
2adbd1e+dirty 17.75 MiB 19.70 MiB 1.96 MiB
95aaf8a 17.75 MiB 19.68 MiB 1.93 MiB
90edad7+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 372.52 ms 437.27 ms 64.74 ms
Size 43.94 MiB 49.27 MiB 5.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a206511+dirty 331.54 ms 356.98 ms 25.44 ms
8ff81c0+dirty 392.47 ms 431.52 ms 39.05 ms
170d5ea+dirty 348.79 ms 406.94 ms 58.15 ms
bb4ea33+dirty 360.73 ms 375.02 ms 14.29 ms
80e4616+dirty 427.31 ms 461.15 ms 33.84 ms
9a81842+dirty 508.08 ms 566.65 ms 58.56 ms
64cd15c+dirty 488.79 ms 483.54 ms -5.24 ms
6bd9054+dirty 376.24 ms 407.76 ms 31.52 ms
73f2455+dirty 369.33 ms 398.90 ms 29.57 ms
23080e5+dirty 347.29 ms 381.87 ms 34.58 ms

App size

Revision Plain With Sentry Diff
a206511+dirty 43.94 MiB 48.90 MiB 4.96 MiB
8ff81c0+dirty 43.94 MiB 48.87 MiB 4.93 MiB
170d5ea+dirty 7.15 MiB 8.42 MiB 1.27 MiB
bb4ea33+dirty 43.94 MiB 48.91 MiB 4.97 MiB
80e4616+dirty 43.94 MiB 49.38 MiB 5.44 MiB
9a81842+dirty 43.94 MiB 48.91 MiB 4.97 MiB
64cd15c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
6bd9054+dirty 43.94 MiB 48.90 MiB 4.96 MiB
73f2455+dirty 43.94 MiB 48.82 MiB 4.88 MiB
23080e5+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.80 ms 1210.89 ms -7.91 ms
Size 3.38 MiB 4.78 MiB 1.39 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
817b2c1+dirty 1211.96 ms 1215.58 ms 3.62 ms
11ded16+dirty 1230.71 ms 1235.52 ms 4.81 ms
4a17c8f+dirty 1226.36 ms 1219.28 ms -7.07 ms
0b64753+dirty 1232.49 ms 1226.96 ms -5.53 ms
0d6e618+dirty 1226.16 ms 1221.66 ms -4.50 ms
8db9631+dirty 1223.60 ms 1224.56 ms 0.96 ms
c1573b3+dirty 1203.33 ms 1202.47 ms -0.86 ms
f17e051+dirty 1193.71 ms 1223.51 ms 29.80 ms
f234eb4+dirty 1227.22 ms 1228.45 ms 1.22 ms

App size

Revision Plain With Sentry Diff
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
817b2c1+dirty 3.38 MiB 4.60 MiB 1.22 MiB
11ded16+dirty 2.63 MiB 4.01 MiB 1.38 MiB
4a17c8f+dirty 3.41 MiB 4.58 MiB 1.17 MiB
0b64753+dirty 2.63 MiB 3.98 MiB 1.35 MiB
0d6e618+dirty 3.41 MiB 4.58 MiB 1.17 MiB
8db9631+dirty 2.63 MiB 4.00 MiB 1.36 MiB
c1573b3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
f17e051+dirty 3.41 MiB 4.67 MiB 1.25 MiB
f234eb4+dirty 2.63 MiB 4.00 MiB 1.37 MiB

antonis
antonis commented Dec 19, 2025
View reviewed changes
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on the addition of 0.83.1 in https://github.com/react-native-community/rn-diff-purge

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.37 ms 1224.07 ms -4.31 ms
Size 3.38 MiB 4.78 MiB 1.39 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9b50d32+dirty 1210.36 ms 1218.41 ms 8.05 ms
083f560+dirty 1215.27 ms 1231.96 ms 16.69 ms
7480abe+dirty 1219.84 ms 1223.60 ms 3.76 ms
d1bfbde+dirty 1221.30 ms 1218.70 ms -2.60 ms
a2bb688+dirty 1244.82 ms 1238.60 ms -6.22 ms
652f785+dirty 1216.42 ms 1212.21 ms -4.21 ms
6c36ba5+dirty 1208.55 ms 1207.38 ms -1.17 ms
9bf5446+dirty 1218.60 ms 1210.45 ms -8.15 ms
f081f58+dirty 1208.37 ms 1215.56 ms 7.19 ms
0dff710+dirty 1194.90 ms 1196.15 ms 1.25 ms

App size

Revision Plain With Sentry Diff
9b50d32+dirty 3.41 MiB 4.59 MiB 1.18 MiB
083f560+dirty 3.19 MiB 4.56 MiB 1.38 MiB
7480abe+dirty 3.19 MiB 4.53 MiB 1.35 MiB
d1bfbde+dirty 3.41 MiB 4.58 MiB 1.17 MiB
a2bb688+dirty 3.19 MiB 4.56 MiB 1.37 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
6c36ba5+dirty 3.38 MiB 4.60 MiB 1.22 MiB
9bf5446+dirty 3.41 MiB 4.59 MiB 1.18 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
0dff710+dirty 3.44 MiB 4.59 MiB 1.15 MiB

@antonis antonis added Blocked and removed ready-to-merge Triggers the full CI test suite labels Dec 19, 2025
@alwx
Copy link
Contributor

alwx commented Dec 19, 2025

We don't have any guidelines regarding that but in general I don't think that bumping RN version for e2e tests is that needed for every minor version, it's just too much hassle with not so many benifits. Maybe we should do it only for major versions?

@antonis antonis changed the title chore(deps): Bump E2E tests to 0.83.1 chore(deps): Bump E2E tests to 0.84-RC Jan 8, 2026
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Jan 8, 2026
antonis
antonis commented Jan 8, 2026
View reviewed changes
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bumped to 0.84.0-rc.0 and will keep this in draft till the final release

@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Jan 16, 2026
antonis
antonis commented Feb 6, 2026
View reviewed changes
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to RC5

@antonis antonis changed the title chore(deps): Bump E2E tests to 0.84-RC chore(deps): Bump E2E tests to 0.84.0 Feb 12, 2026
antonis
antonis commented Feb 12, 2026
View reviewed changes
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to 0.84.0 final since it became available with 5b01251

antonis and others added 4 commits February 12, 2026 09:45
@antonis
Merge branch 'main' into antonis/rn-0.83.1
46348ad
@antonis
Merge branch 'main' into antonis/rn-0.83.1
414e1c4
@antonis
Merge branch 'main' into antonis/rn-0.83.1
fed421b
@antonis @claude
fix(e2e): Use install_modules_dependencies for react-native-launch-ar…
7162526 
…guments

Enhances the patch script to use install_modules_dependencies() instead
of hardcoded React/React-Core dependencies. This is the modern approach
for React Native 0.60+ that properly handles all framework configurations
(static, dynamic, etc.) and automatically resolves the correct React Native
dependencies.

This should fix the "Undefined symbols: _RCTRegisterModule" error when
building RN 0.84.0 with dynamic frameworks on iOS.

The patch now uses the same defensive pattern as RNSentry.podspec, with
a fallback to React-Core for older RN versions that don't have
install_modules_dependencies defined.

Tested locally and verified:
- Patch successfully replaces s.dependency "React"
- Generated Ruby syntax is valid
- Idempotent (safe to run multiple times)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@antonis antonis marked this pull request as ready for review February 13, 2026 15:28
lucas-zimerman
lucas-zimerman approved these changes Feb 13, 2026
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@alwx alwx Awaiting requested review from alwx alwx is a code owner

Assignees

No one assigned

Labels

Blocked ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonis @alwx @lucas-zimerman